** Fix for #431 ** #435
Closed
** Fix for #431 ** #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> See https://bugzilla.mozilla.org/show_bug.cgi?id=559506 -> Removed the javascript:void(0) href for anchor elements in the multiselect dropdown -> Added a tabindex = 0 to keep the anchors focus-able -> Added code to remove any text selection when using shift+click -> Handles the checkbox selection manually when done using shift+click on its label
This was referenced Nov 26, 2014
-> Fixed a failure on test for davidstutz#405 due to the code changes
|
I will go with #435, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: This pull request only fixes the problem #431.
I've submitted #439 that is based on this commit but also includes performance improvements for the shift+click range selection. I'll leave which one you want to merge at your discretion, just reject the other one.
-> See https://bugzilla.mozilla.org/show_bug.cgi?id=559506
-> Removed the javascript:void(0) href for anchor elements in the multiselect dropdown
-> Added a tabindex = 0 to keep the anchors focus-able
-> Added code to remove any text selection when using shift+click
-> Handles the checkbox selection manually when done using shift+click on its label